Simplify running E2E test script on local. #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
previously approved these changes
Mar 12, 2025
Simplifications. Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
reviewed
Mar 12, 2025
Set `skip-setup` to false which makes sense when running for the first time. Co-authored-by: Cas Donoghue <[email protected]>
|
CI failure is not due to this change, will be fixed by #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies running E2E test script on local by introducing skip set up and integrations to test options.
When first running E2E tests, setup is required. For the next steps setup can be skipped.